fix: remove unused tar deendency #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that tar is declared in dependencies, but isn't actually used. This causes 2 MB of dependencies to be pulled into one's node_modules on every cacache install. I was unable to track back when the dependency actually stopped being used; looks like at least several major versions were shipped with it unnecessarily. If this is confirmed, it'd be great to push this fix to older major versions if possible.
|
@wojtekmaj Thank you for pointing this out! We don't accept dependency updates by policy, so I'm closing this PR, but I'll confirm this and remove it once confirmed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that tar is declared in dependencies, but isn't actually used. This causes 2 MB of dependencies to be pulled into one's node_modules on every cacache install.
I was unable to track back when the dependency actually stopped being used; looks like at least several major versions were shipped with it unnecessarily.
If this is confirmed, it'd be great to push this fix to older major versions if possible.